netdev - Re: [PATCH v2 net 0/8] net: bcmgenet: minor bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e34d507-a342-3910-bac9-a5c829ad8d22@gmail.com>
Date:   Thu, 9 Mar 2017 17:45:32 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Doug Berger <opendmb@...il.com>
Cc:     pgynther@...gle.com, jaedon.shin@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net 0/8] net: bcmgenet: minor bug fixes

On 03/09/2017 04:58 PM, Doug Berger wrote:
> v2: Accidentally sent the wrong set after rebasing.
> 
> This collection contains a number of fixes for minor issues with the
> bcmgenet driver most of which were present in the initial submission
> of the driver.

This entire series looks great, thanks for getting this out!

> 
> Some bugs were uncovered by inspection prior to the upcoming update for
> GENETv5 support:
>   net: bcmgenet: correct the RBUF_OVFL_CNT and RBUF_ERR_CNT MIB values
>   net: bcmgenet: correct MIB access of UniMAC RUNT counters
>   net: bcmgenet: reserved phy revisions must be checked first
>   net: bcmgenet: synchronize irq0 status between the isr and task
> 
> Others bugs were found in power management testing:
>   net: bcmgenet: power down internal phy if open or resume fails
>   net: bcmgenet: Power up the internal PHY before probing the MII
>   net: bcmgenet: decouple flow control from bcmgenet_tx_reclaim
>   net: bcmgenet: add begin/complete ethtool ops
> 
> Doug Berger (7):
>   net: bcmgenet: correct the RBUF_OVFL_CNT and RBUF_ERR_CNT MIB values
>   net: bcmgenet: correct MIB access of UniMAC RUNT counters
>   net: bcmgenet: reserved phy revisions must be checked first
>   net: bcmgenet: power down internal phy if open or resume fails
>   net: bcmgenet: synchronize irq0 status between the isr and task
>   net: bcmgenet: Power up the internal PHY before probing the MII
>   net: bcmgenet: decouple flow control from bcmgenet_tx_reclaim
> 
> Edwin Chan (1):
>   net: bcmgenet: add begin/complete ethtool ops
> 
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c | 206 ++++++++++++++++++-------
>  drivers/net/ethernet/broadcom/genet/bcmgenet.h |  16 +-
>  2 files changed, 158 insertions(+), 64 deletions(-)
> 


-- 
Florian