netdev - Re: [PATCH v3 net-next 7/9] net: stmicro: prepare irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2017 08:18:30 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Joao Pinto <Joao.Pinto@...opsys.com>
Cc:     kbuild-all@...org, davem@...emloft.net, peppe.cavallaro@...com,
        alexandre.torgue@...com, niklas.cassel@...s.com,
        netdev@...r.kernel.org, Joao Pinto <Joao.Pinto@...opsys.com>
Subject: Re: [PATCH v3 net-next 7/9] net: stmicro: prepare irq_status for mtl

Hi Joao,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Joao-Pinto/prepare-mac-operations-for-multiple-queues/20170310-062934
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

All warnings (new ones prefixed by >>):

   In file included from arch/sh/include/asm/io.h:26:0,
                    from include/linux/scatterlist.h:8,
                    from include/linux/dma-mapping.h:10,
                    from include/linux/skbuff.h:34,
                    from include/linux/if_ether.h:23,
                    from include/uapi/linux/ethtool.h:18,
                    from include/linux/ethtool.h:17,
                    from drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:18:
   drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c: In function 'dwmac4_irq_mtl_status':
   drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:422:32: error: 'ioaddr' undeclared (first use in this function)
     u32 mtl_int_qx_status = readl(ioaddr + MTL_INT_STATUS);
                                   ^
   arch/sh/include/mach-common/mach/mangle-port.h:42:23: note: in definition of macro 'ioswabl'
    # define ioswabl(x)  (x)
                          ^
>> arch/sh/include/asm/io.h:40:47: note: in expansion of macro '__raw_readl'
    #define readl_relaxed(c) ({ u32 __v = ioswabl(__raw_readl(c)); __v; })
                                                  ^~~~~~~~~~~
>> arch/sh/include/asm/io.h:50:31: note: in expansion of macro 'readl_relaxed'
    #define readl(a)  ({ u32 r_ = readl_relaxed(a); rmb(); r_; })
                                  ^~~~~~~~~~~~~
>> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:422:26: note: in expansion of macro 'readl'
     u32 mtl_int_qx_status = readl(ioaddr + MTL_INT_STATUS);
                             ^~~~~
   drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:422:32: note: each undeclared identifier is reported only once for each function it appears in
     u32 mtl_int_qx_status = readl(ioaddr + MTL_INT_STATUS);
                                   ^
   arch/sh/include/mach-common/mach/mangle-port.h:42:23: note: in definition of macro 'ioswabl'
    # define ioswabl(x)  (x)
                          ^
>> arch/sh/include/asm/io.h:40:47: note: in expansion of macro '__raw_readl'
    #define readl_relaxed(c) ({ u32 __v = ioswabl(__raw_readl(c)); __v; })
                                                  ^~~~~~~~~~~
>> arch/sh/include/asm/io.h:50:31: note: in expansion of macro 'readl_relaxed'
    #define readl(a)  ({ u32 r_ = readl_relaxed(a); rmb(); r_; })
                                  ^~~~~~~~~~~~~
>> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:422:26: note: in expansion of macro 'readl'
     u32 mtl_int_qx_status = readl(ioaddr + MTL_INT_STATUS);
                             ^~~~~

vim +/readl +422 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c

   406				x->pcs_speed = SPEED_100;
   407			else
   408				x->pcs_speed = SPEED_10;
   409	
   410			x->pcs_duplex = (status & GMAC_PHYIF_CTRLSTATUS_LNKMOD_MASK);
   411	
   412			pr_info("Link is Up - %d/%s\n", (int)x->pcs_speed,
   413				x->pcs_duplex ? "Full" : "Half");
   414		} else {
   415			x->pcs_link = 0;
   416			pr_info("Link is Down\n");
   417		}
   418	}
   419	
   420	static int dwmac4_irq_mtl_status(struct mac_device_info *hw, u32 chan)
   421	{
 > 422		u32 mtl_int_qx_status = readl(ioaddr + MTL_INT_STATUS);
   423		void __iomem *ioaddr = hw->pcsr;
   424		int ret = 0;
   425	
   426		/* Check MTL Interrupt */
   427		if (mtl_int_qx_status & MTL_INT_QX(chan)) {
   428			/* read Queue x Interrupt status */
   429			u32 status = readl(ioaddr + MTL_CHAN_INT_CTRL(chan));
   430	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (44339 bytes)