netdev - Re: [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170310023317.GJ22101@lunn.ch>
Date:   Fri, 10 Mar 2017 03:33:17 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove

> -static int _mv88e6xxx_atu_cmd(struct mv88e6xxx_chip *chip, u16 fid, u16 cmd)
> -{
> -	u16 val;
> -	int err;
> -
> -	if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_G1_ATU_FID)) {
> -		err = mv88e6xxx_g1_write(chip, GLOBAL_ATU_FID, fid);
> -		if (err)
> -			return err;

I think this removal makes MV88E6XXX_FLAG_G1_ATU_FID unused. It should
be removed from mv88e6xxx.h as well.

   Andrew