netdev - Re: [PATCH net, v1] dccp/tcp: fix routing redirect race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1489119824.28631.26.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Thu, 09 Mar 2017 20:23:44 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jon Maxwell <jmaxwell37@...il.com>
Cc:     gerrit@....abdn.ac.uk, davem@...emloft.net, edumazet@...gle.com,
        andreyknvl@...gle.com, kuznet@....inr.ac.ru, jmorris@...ei.org,
        yoshfuji@...ux-ipv6.org, kaber@...sh.net, ncardwell@...gle.com,
        dccp@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, jmaxwell@...hat.com,
        Eric Garver <egarver@...hat.com>,
        Hannes Sowa <hsowa@...hat.com>
Subject: Re: [PATCH net, v1] dccp/tcp: fix routing redirect race

On Fri, 2017-03-10 at 14:31 +1100, Jon Maxwell wrote:
> As Eric Dumazet pointed out this also needs to be fixed in IPv6.
> v1: Contains the IPv6 patch as well.

> Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.")
> Cc: Eric Garver <egarver@...hat.com>
> Cc: Hannes Sowa <hsowa@...hat.com>
> Signed-off-by: Jon Maxwell <jmaxwell37@...il.com>
> ---
>  net/dccp/ipv4.c     | 3 ++-
>  net/ipv4/tcp_ipv4.c | 3 ++-
>  net/ipv6/tcp_ipv6.c | 8 +++++---

Hi Jon.

You forgot net/dccp/ipv6.c 

dccp_v6_err() has the same issue.