netdev - Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d48f786ea0deaafabff53c90da19a2fb@codeaurora.org>
Date:   Fri, 10 Mar 2017 00:34:54 -0700
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     netdev@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>,
        netdev-owner@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp
 and udp

> Well, then you need to make sure ipprot->early_demux is read once in 
> the
> callers, like ip_rcv_finish(), otherwise compiler could read it twice
> and we could deref a NULL pointer.
> 
> ipprot = rcu_dereference(inet_protos[protocol]);
> if (ipprot && ipprot->early_demux) {
>     ipprot->early_demux(skb);   // crash

Thanks Eric. I'll update this.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project