netdev - Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mvcqmjr2.fsf@miraculix.mork.no>
Date:   Sun, 12 Mar 2017 19:29:21 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Yasuaki Ishimatsu <yasu.isimatu@...il.com>
Cc:     netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
        izumi.taku@...fujitsu.com
Subject: Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

Yasuaki Ishimatsu <yasu.isimatu@...il.com> writes:

> The fjes driver is used only by FUJITSU servers and almost of all
> servers in the world never use it. But currently if ACPI PNP0C02
> is defined in the ACPI table, the following message is always shown:
>
>  "FUJITSU Extended Socket Network Device Driver - version 1.2
>   - Copyright (c) 2015 FUJITSU LIMITED"

Matching on PNP0C02 is fundamentally wrong. It's a way to load a device
driver on all ACPI systems.  You should not do that. I don't think it is
fair to make everyone suffer because of your inability to properly
narrow down the driver matching rules.

Could we please just delete the whole MODULE_DEVICE_TABLE() from this
driver until a proper solution is found? That way we don't need to
blacklist the driver everywhere.

Bjørn