lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <25a0e468-e288-b9d5-068e-90d4fdfe6b32@cumulusnetworks.com> Date: Mon, 13 Mar 2017 09:15:32 -0600 From: David Ahern <dsa@...ulusnetworks.com> To: Ido Schimmel <idosch@...sch.org> Cc: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com, mlxsw@...lanox.com, shm@...ulusnetworks.com, kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net, lorenzo@...gle.com, mateusz.bajorski@...ia.com Subject: Re: [patch net-next 04/10] net: Add netif_is_vrf_master helper On 3/13/17 9:01 AM, Ido Schimmel wrote: > On Mon, Mar 13, 2017 at 08:39:19AM -0600, David Ahern wrote: >> On 3/13/17 1:38 AM, Jiri Pirko wrote: >>> From: Ido Schimmel <idosch@...lanox.com> >>> >>> Drivers capable of offloading VRF configurations need to know the ports >>> are enslaved to an actual VRF device and not some other L3 master. >>> >>> Add a flag to indicate netdev is a VRF master and a corresponding >>> helper. >>> >>> Signed-off-by: Ido Schimmel <idosch@...lanox.com> >>> Signed-off-by: Jiri Pirko <jiri@...lanox.com> >>> --- >>> drivers/net/vrf.c | 2 +- >>> include/linux/netdevice.h | 8 ++++++++ >>> 2 files changed, 9 insertions(+), 1 deletion(-) >>> >> >> IFF_VRF_MASTER was renamed IFF_L3MDEV_MASTER 18 months ago. > > But IFF_L3MDEV_MASTER isn't specific to the VRF driver. It can be set by > other drivers including future ones that might be introduced. I need to > allow enslavement to a VRF master, but reject others. > Why isn't an L3MDEV associated with a FIB table sufficient? ie., the L3MDEV_MASTER flag is set and the driver impements l3mdev_fib_table. At that point, what is specific to a VRF device that the offload relies on?
Powered by blists - more mailing lists