netdev - Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170313163624.GD3953@lunn.ch>
Date:   Mon, 13 Mar 2017 17:36:24 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     sean.wang@...iatek.com
Cc:     f.fainelli@...il.com, vivien.didelot@...oirfairelinux.com,
        matthias.bgg@...il.com, robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        davem@...emloft.net, Landen.Chao@...iatek.com, keyhaede@...il.com,
        objelf@...il.com
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530
 binding

> +- mediatek,reset-pin: Phandle to the pinctrl node used for the reset. Which
> +	must be required if the property mediatek,mcm of specified as
> +	"disabled". See
> +	Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt for
> +	the mediatek pintcrl setting for the details.

Hi Sean

This appears to be a plan GPIO line. Marvell has the same. It would be
nice to be consistent with the naming. From
Documentation/devicetree/bindings/net/dsa/marvell.txt

Optional properties:

- reset-gpios           : Should be a gpio specifier for a reset line

  Andrew