netdev - Re: [PATCH] vlan: support ingress/egress priority map flushing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170312.233014.417497020070639639.davem@davemloft.net>
Date:   Sun, 12 Mar 2017 23:30:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     thierry@...ystems.be
Cc:     netdev@...r.kernel.org, greearb@...delatech.com
Subject: Re: [PATCH] vlan: support ingress/egress priority map flushing

From: Thierry Du Tre <thierry@...ystems.be>
Date: Fri, 10 Mar 2017 15:41:35 +0100

> --- a/include/uapi/linux/if_vlan.h
> +++ b/include/uapi/linux/if_vlan.h
> @@ -20,6 +20,8 @@
>  enum vlan_ioctl_cmds {
>  	ADD_VLAN_CMD,
>  	DEL_VLAN_CMD,
> +	FLUSH_VLAN_INGRESS_PRIORITY_CMD,
> +	FLUSH_VLAN_EGRESS_PRIORITY_CMD,
>  	SET_VLAN_INGRESS_PRIORITY_CMD,
>  	SET_VLAN_EGRESS_PRIORITY_CMD,
>  	GET_VLAN_INGRESS_PRIORITY_CMD,

You definitely cannot insert new command values in the middle of
existing commands, this changes the value of SET/GET/etc. thus
breaking existing userspace.