netdev - Re: [PATCH net-next 00/13] nfp: XDP adjust head support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170312.234335.1328185272205305351.davem@davemloft.net>
Date:   Sun, 12 Mar 2017 23:43:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com, kubakici@...pl
Subject: Re: [PATCH net-next 00/13] nfp: XDP adjust head support

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri, 10 Mar 2017 10:38:26 -0800

> This series adds support for XDP adjust head.  Bulk of the code
> is actually just paying technical debt.  On reconfiguration request
> nfp was allocating new resources separately leaving device running
> with the existing set of rings.  We used to manage the new resources
> in special ring set structures.  This set is simply separating the
> datapath part of the device structure from the control information
> allowing the new datapath structure to be allocated with all new
> memory and rings.  The swap operation is now greatly simplified.
> We also save a lot of parameter passing this way.  Hopefully the churn
> is worth the negative diffstat.
> 
> Support for XDP adjust head is done in a pretty standard way.  NFP
> is a bit special because it prepends metadata before packet data
> so we have to do a bit of memcpying in case XDP will run.  We also
> luck out a little bit because the fact that we already have prepend
> space allocated means that one byte is enough to store the extra XDP
> space (256 of standard prepend space is a bit inconvenient since
> it would normally require 16bits or boolean with additional shifts).

Series applied, thanks.