netdev - Re: [net-next:master 53/61] net/sched/sch_tbf.c:399:3: note: in expansion of macro 'if'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170313.000030.1021237791287933829.davem@davemloft.net>
Date:   Mon, 13 Mar 2017 00:00:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fengguang.wu@...el.com
Cc:     jkosina@...e.cz, kbuild-all@...org, netdev@...r.kernel.org
Subject: Re: [net-next:master 53/61] net/sched/sch_tbf.c:399:3: note: in
 expansion of macro 'if'

From: kbuild test robot <fengguang.wu@...el.com>
Date: Mon, 13 Mar 2017 14:49:27 +0800

>>> net/sched/sch_tbf.c:399:3: note: in expansion of macro 'if'
>       if (child != &noop_qdisc);
>       ^~
>    net/sched/sch_tbf.c:400:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
>        qdisc_hash_add(child, true);
>        ^~~~~~~~~~~~~~

Now fixes as follows:

====================
[PATCH] sch_tbf: Remove bogus semicolon in if() conditional.

Fixes: 49b499718fa1 ("net: sched: make default fifo qdiscs appear in the dump")
Reported-by: kbuild test robot <fengguang.wu@...el.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
---
 net/sched/sch_tbf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c
index 40c29a8..9850126 100644
--- a/net/sched/sch_tbf.c
+++ b/net/sched/sch_tbf.c
@@ -396,7 +396,7 @@ static int tbf_change(struct Qdisc *sch, struct nlattr *opt)
 					  q->qdisc->qstats.backlog);
 		qdisc_destroy(q->qdisc);
 		q->qdisc = child;
-		if (child != &noop_qdisc);
+		if (child != &noop_qdisc)
 			qdisc_hash_add(child, true);
 	}
 	q->limit = qopt->limit;
-- 
2.1.0