netdev - Re: [PATCH] Enable tx timestamping on loopback and dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170313103532.GB1875@localhost.localdomain>
Date:   Mon, 13 Mar 2017 11:35:32 +0100
From:   Richard Cochran <richardcochran@...il.com>
To:     Ezequiel Lara Gomez <ezegomez@...zon.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] Enable tx timestamping on loopback and dummy

On Sun, Mar 12, 2017 at 08:39:03PM +0000, Ezequiel Lara Gomez wrote:
> On Sun, Mar 12, 2017 at 05:30:00PM +0100, Richard Cochran wrote:
> > And while you are at it, explain why #1 is needed.
> 
> Certainly - 2 (and 3) come from checkpatch.pl suggestions 
> (I'm mostly following through https://kernelnewbies.org/FirstKernelPatch ), 
> so as suggested I've broken them into a separate patch, being
> styling related only (at least according to that script output).
> 
> The intent behind 1 is helping developing code that does TX timestamping
> - I lost a good chunk of time toying with it until I realised 127.0.0.1
> could not do TX timestamping because lo did not implement it.

IMHO this is not a very convincing reason, but I won't object if
others agree with this change.

In any case, the motivation belongs in the commit message...

Thanks,
Richard