netdev - Re: [PATCH net-next 2/3] vxlan: fix snooping for link-local IPv6 addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170314155656.1446a358@griffin>
Date:   Tue, 14 Mar 2017 15:56:56 +0100
From:   Jiri Benc <jbenc@...hat.com>
To:     Matthias Schiffer <mschiffer@...verse-factory.net>
Cc:     davem@...emloft.net, hannes@...essinduktion.org, pshelar@....org,
        aduyck@...antis.com, roopa@...ulusnetworks.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] vxlan: fix snooping for link-local IPv6
 addresses

On Fri, 10 Mar 2017 23:39:43 +0100, Matthias Schiffer wrote:
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -941,16 +941,24 @@ static int vxlan_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb,
>   */
>  static bool vxlan_snoop(struct net_device *dev,
>  			union vxlan_addr *src_ip, const u8 *src_mac,
> -			__be32 vni)
> +			__u32 src_ifindex, __be32 vni)

Just "u32", please. No double underscores for u32 inside the
kernel-only code. (Also in other places in this patch.)

Thanks,

 Jiri