netdev - Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2017 12:07:20 -0400
From:   YASUAKI ISHIMATSU <yasu.isimatu@...il.com>
To:     "Izumi, Taku" <izumi.taku@...fujitsu.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>, yasu.isimatu@...il.com
Subject: Re: [PATCH v2] fjes: Do not load fjes driver if system does not have
 extended socket device.



On 03/12/2017 09:02 PM, Izumi, Taku wrote:
> Ishimatsu-san,
>
>  Sorry for my late response.
>
>>
>> Which tree did you apply the patch to?
>>
>> The patch can apply to net-next tree with no conflicts as follows:
>
>   Not net-next but net tree:
>     git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git

I'll update the patch soon.

Thanks,
Yasuaki Ishimatsu

>
>   I'll review and test your patch soon.
>
>   Sincerely,
>   Taku Izumi
>
>>
>> # git clone
>> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
>> Cloning into 'net-next'...
>> remote: Counting objects: 5265118, done.
>> remote: Compressing objects: 100% (805485/805485), done.
>> Receiving objects: 100% (5265118/5265118), 910.11 MiB | 23.42 MiB/s, done.
>> remote: Total 5265118 (delta 4419240), reused 5264459 (delta 4418809)
>> Resolving deltas: 100% (4419240/4419240), done.
>> Checking out files: 100% (58005/58005), done.
>> # head -n 30 fjes.patch
>> Subject: [PATCH v2] fjes: Do not load fjes driver if system does not have
>> extended socket device.
>> Date: Wed, 8 Mar 2017 16:05:18 -0500
>> From: Yasuaki Ishimatsu <yasu.isimatu@...il.com>
>> To: netdev@...r.kernel.org
>> CC: David Miller <davem@...emloft.net>, izumi.taku@...fujitsu.com
>>
>> The fjes driver is used only by FUJITSU servers and almost of all servers
>> in the world never use it. But currently if ACPI PNP0C02 is defined in the
>> ACPI table, the following message is always shown:
>>
>>   "FUJITSU Extended Socket Network Device Driver - version 1.2
>>    - Copyright (c) 2015 FUJITSU LIMITED"
>>
>> The message makes users confused because there is no reason that the message
>> is shown in other vendor servers.
>>
>> To avoid the confusion, the patch adds a check that the server has a extended
>> socket device or not.
>>
>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
>> CC: Taku Izumi <izumi.taku@...fujitsu.com>
>> ---
>> v2:
>> 	- Order local variable declarations from longest to shortest line
>>
>>   drivers/net/fjes/fjes_main.c | 52
>> +++++++++++++++++++++++++++++++++++++++-----
>>   1 file changed, 47 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
>> index b77e4ecf..a57c2cb 100644 # cd net-next/ # git am ../fjes.patch
>> Applying: fjes: Do not load fjes driver if system does not have extended
>> socket device.
>> #
>>
>>
>> Thanks,
>> Yasuaki Ishimatsu
>