netdev - Re: [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170314175843.GY2079@mtr-leonro.local>
Date:   Tue, 14 Mar 2017 19:58:43 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Yuval Shaia <yuval.shaia@...cle.com>
Cc:     benve@...co.com, dgoodell@...co.com, dledford@...hat.com,
        sean.hefty@...el.com, hal.rosenstock@...il.com, monis@...lanox.com,
        davem@...emloft.net, linux-rdma@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32
 function

On Tue, Mar 14, 2017 at 04:01:57PM +0200, Yuval Shaia wrote:
> This logic seems to be duplicated in (at least) three separate files.
> Move it to one place so code can be re-use.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@...cle.com>
> ---
> v0 -> v1:
> 	* Add missing #include
> 	* Rename to genaddrconf_ifid_eui48
> v1 -> v2:
> 	* Reset eui[0] to default if dev_id is used
> v2 -> v3:
> 	* Add helper function to avoid re-setting eui[0] to default if
> 	  dev_id is used
> v3 -> v4:
> 	* Remove RXE wrappers
> 	* Remove addrconf_addr_eui48_xor and do the eui[0] ^= 2 in the
> 	  basic implementation
> ---
>  drivers/infiniband/hw/usnic/usnic_common_util.h | 11 +++-------
>  drivers/infiniband/sw/rxe/rxe.c                 |  4 +++-
>  drivers/infiniband/sw/rxe/rxe_loc.h             |  2 --
>  drivers/infiniband/sw/rxe/rxe_net.c             | 28 -------------------------
>  drivers/infiniband/sw/rxe/rxe_verbs.c           |  4 +++-
>  include/net/addrconf.h                          | 22 +++++++++++++++----
>  6 files changed, 27 insertions(+), 44 deletions(-)
>

Thanks, Yuval.
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)