netdev - Re: [PATCH net-next 07/12] net: bcmgenet: clear status to reduce spurious interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72c62daf-24f3-de13-e81b-4742993e1de5@gmail.com>
Date:   Mon, 13 Mar 2017 17:56:56 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Doug Berger <opendmb@...il.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, davem@...emloft.net,
        rafal@...ecki.pl, xow@...gle.com, joel@....id.au,
        jon.mason@...adcom.com, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        pgynther@...gle.com, jaedon.shin@...il.com
Subject: Re: [PATCH net-next 07/12] net: bcmgenet: clear status to reduce
 spurious interrupts

On 03/13/2017 05:41 PM, Doug Berger wrote:
> Since the DMA interrupt status is latched and the DMA servicing can be
> polled, it is a good idea to clear the latched status of a DMA interrupt
> before performing the service that would be invoked by the interrupt.
> 
> This prevents old status from causing spurious interrupts when the
> interrupt is unmasked at a later time.
> 
> Signed-off-by: Doug Berger <opendmb@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian