netdev - Re: [PATCH] net: ethernet: aquantia: set net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0284a60-e33d-389e-3798-bd8827424cb0@aquantia.com>
Date:   Tue, 14 Mar 2017 04:32:38 +0300
From:   Pavel Belous <pavel.belous@...antia.com>
To:     David Arcari <darcari@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is
 changed


On 03/14/2017 02:07 AM, David Arcari wrote:
> When the aquantia device mtu is changed the net_device structure is not
> updated.  As a result the ip command does not properly reflect the mtu change.
>
> Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
> assignment ndev->mtu = new_mtu;  This is not true in the case where the driver
> has a ndo_change_mtu routine.
>
> Fixes: 5513e16421cb ("net: ethernet: aquantia: Fixes for aq_ndev_change_mtu")
>
> Cc: Pavel Belous <Pavel.Belous@...antia.com>
> Signed-off-by: David Arcari <darcari@...hat.com>
> ---
>  drivers/net/ethernet/aquantia/atlantic/aq_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_main.c b/drivers/net/ethernet/aquantia/atlantic/aq_main.c
> index dad6362..d05fbfd 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_main.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_main.c
> @@ -98,6 +98,7 @@ static int aq_ndev_change_mtu(struct net_device *ndev, int new_mtu)
>
>  	if (err < 0)
>  		goto err_exit;
> +	ndev->mtu = new_mtu;
>
>  	if (netif_running(ndev)) {
>  		aq_ndev_close(ndev);
>

Tested-by: Pavel Belous <pavel.belous@...antia.com>