netdev - Re: [PATCH] usbnet: smsc95xx: Reduce logging noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59ee1010-7135-1225-84b3-a402904a7f7e@roeck-us.net>
Date:   Mon, 13 Mar 2017 19:13:11 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     David Miller <davem@...emloft.net>
Cc:     steve.glendinning@...well.net, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usbnet: smsc95xx: Reduce logging noise

On 03/13/2017 03:32 PM, David Miller wrote:
> From: Guenter Roeck <linux@...ck-us.net>
> Date: Fri, 10 Mar 2017 17:45:21 -0800
>
>> An insert/remove stress test generated the following log message sequence.
> ...
>> Use netdev_dbg() instead of netdev_warn() for the repeating messages
>> to reduce logging noise.
>>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>
> The problem I have with changes like this is that outside of your
> stress test situation these messages are extremely useful but will
> now be hidden making diagnosis of problems more difficult.
>

In general I agree, but in this case the calling code also generates
another set of error messages, which I considered a bit excessive.

No problem, though, we can live with the noise.

Guenter