netdev - Re: [RFC v1 for accelerated IPoIB 04/25] IB/verb: Add ipoib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170314070109.GD79937@knc-06.sc.intel.com>
Date:   Tue, 14 Mar 2017 00:01:09 -0700
From:   "Vishwanathapura, Niranjana" <niranjana.vishwanathapura@...el.com>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:     Erez Shitrit <erezsh@...lanox.com>, dledford@...hat.com,
        linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
        valex@...lanox.com, leonro@...lanox.com, saedm@...lanox.com,
        erezsh@....mellanox.co.il
Subject: Re: [RFC v1 for accelerated IPoIB 04/25] IB/verb: Add ipoib_options
 struct and API

On Mon, Mar 13, 2017 at 02:01:36PM -0600, Jason Gunthorpe wrote:
>> +	/* multicast */
>> +	int (*attach_mcast)(struct net_device *dev, struct ib_device *hca,
>> +			    union ib_gid *gid, u16 lid, int set_qkey);
>> +	int (*detach_mcast)(struct net_device *dev, struct ib_device *hca,
>> +			    union ib_gid *gid, u16 lid);
>
>It would make more sense to store the struct ib_device pointer in the
>struct rdma_netdev.
>

Agree that it shouldn't be a function parameters.
For opa_vnic, I found it convenient to store ib_device pointer in client and 
device private structures as those will be available in most places anyhow.

Niranjana