netdev - RE: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFB052E@AcuExch.aculab.com>
Date:   Tue, 14 Mar 2017 11:04:54 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Doug Berger' <opendmb@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "rafal@...ecki.pl" <rafal@...ecki.pl>,
        "xow@...gle.com" <xow@...gle.com>,
        "joel@....id.au" <joel@....id.au>,
        "jon.mason@...adcom.com" <jon.mason@...adcom.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "pgynther@...gle.com" <pgynther@...gle.com>,
        "jaedon.shin@...il.com" <jaedon.shin@...il.com>
Subject: RE: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for
 unknown ioctl commands

From: Doug Berger
> Sent: 14 March 2017 00:42
> This commit changes the ioctl handling behavior to return the
> EOPNOTSUPP error code instead of the EINVAL error code when an
> unknown ioctl command value is detected.
> 
> It also removes some redundant parsing of the ioctl command value
> and allows the SIOCSHWTSTAMP value to be handled.

A better description would seem to be:
Remove checks on ioctl command and just forward all ioctl requests
to phy_mii_ioctl().

I also thought the 'generic' response to an unknown ioctl command
was ENOTTY.

	David