netdev - Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1d97437-ed79-7a2b-d865-cd4e72173057@gmail.com>
Date:   Wed, 15 Mar 2017 17:33:28 +0200
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Alexander Duyck <alexander.duyck@...il.com>
Subject: Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path



On 14/03/2017 4:21 PM, Eric Dumazet wrote:
> On Tue, 2017-03-14 at 06:34 -0700, Eric Dumazet wrote:
>
>> So I will leave this to Mellanox for XDP tests and upstreaming this,
>> and will stop arguing with you, this is going nowhere.
>
> Tariq, I will send a v2, including these changes (plus the missing
> include of yesterday)
>
> One is to make sure high order allocations remove __GFP_DIRECT_RECLAIM
>
> The other is changing mlx4_en_recover_from_oom() to increase by
> one rx_alloc_order instead of plain reset to rx_pref_alloc_order
>
> Please test XDP and tell me if you find any issues ?
> Thanks !

I can do the XDP check tomorrow, and complete the patch review.
I will let you updated.

(I am replying this on V2 as well)

Regards,
Tariq