netdev - Re: [PATCH net] net/openvswitch: Set the ipv6 source tunnel key address attribute correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170315172859.6c953e7f@griffin>
Date:   Wed, 15 Mar 2017 17:28:59 +0100
From:   Jiri Benc <jbenc@...hat.com>
To:     Or Gerlitz <ogerlitz@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paul Blakey <paulb@...lanox.com>,
        Roi Dayan <roid@...lanox.com>, mlxsw@...lanox.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net/openvswitch: Set the ipv6 source tunnel key
 address attribute correctly

On Wed, 15 Mar 2017 18:10:47 +0200, Or Gerlitz wrote:
> When dealing with ipv6 source tunnel key address attribute
> (OVS_TUNNEL_KEY_ATTR_IPV6_SRC) we are wrongly setting the tunnel
> dst ip, fix that.
> 
> Fixes: 6b26ba3a7d95 ('openvswitch: netlink attributes for IPv6 tunneling')
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> Reported-by: Paul Blakey <paulb@...lanox.com>

Acked-by: Jiri Benc <jbenc@...hat.com>

> Jiri, so I have few wild guesses how things work w.o this fix, e.g: 
> 
> (1) typically the tunnel source ip attribute isn't set by user-space

I think this is it.

Thanks for the fix!

 Jiri