netdev - Re: [PATCH] net: sun: sungem: rix a possible null dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC=8w91tNO1LM23V=vp4spS9QGKwMCB1T7HVM7=r1WOfH_XOSQ@mail.gmail.com>
Date:   Wed, 15 Mar 2017 22:45:03 +0100
From:   Philippe Reynes <tremyfr@...il.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     davem@...emloft.net, mugunthanvnm@...com, jarod@...hat.com,
        felipe.balbi@...ux.intel.com, edumazet@...gle.com, fw@...len.de,
        dan.carpenter@...cle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sun: sungem: rix a possible null dereference

Hi Sergei,

On 3/15/17, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote:
> Hello!
>
> On 3/15/2017 12:23 AM, Philippe Reynes wrote:
>
>> The function gem_begin_auto_negotiation dereference
>> the pointer ep before testing if it's null. This
>> patch add a check on ep before dereferencing it.
>>
>> This issue was added by the patch 92552fdd557:
>> "net: sun: sungem: use new api ethtool_{get|set}_link_ksettings".
>
>     There's Fixes: tag for that now, described in
> Documentation/process/submitting-patches.rst...

Thanks a lot for pointing me this tag.
I'm sending a v2 of this patch with this tag.

>> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>> Signed-off-by: Philippe Reynes <tremyfr@...il.com>
> [...]
>
> MBR, Sergei
>

Thanks,
Philippe