netdev - Re: [PATCH] nl80211: fix dumpit error path RTNL deadlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170315.145902.1038598966216203408.davem@davemloft.net>
Date:   Wed, 15 Mar 2017 14:59:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     johannes@...solutions.net
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        sowmini.varadhan@...cle.com, dvyukov@...gle.com,
        johannes.berg@...el.com
Subject: Re: [PATCH] nl80211: fix dumpit error path RTNL deadlocks

From: Johannes Berg <johannes@...solutions.net>
Date: Wed, 15 Mar 2017 14:29:13 +0100

> From: Johannes Berg <johannes.berg@...el.com>
> 
> Sowmini pointed out Dmitry's RTNL deadlock report to me, and it turns out
> to be perfectly accurate - there are various error paths that miss unlock
> of the RTNL.
> 
> To fix those, change the locking a bit to not be conditional in all those
> nl80211_prepare_*_dump() functions, but make those require the RTNL to
> start with, and fix the buggy error paths. This also let me use sparse
> (by appropriately overriding the rtnl_lock/rtnl_unlock functions) to
> validate the changes.
> 
> Reported-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Johannes, I assume I will get this in a future pull request?