netdev - Re: [PATCH net] net: properly release sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170315.153811.1553669986617106938.davem@davemloft.net>
Date:   Wed, 15 Mar 2017 15:38:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net: properly release sk_frag.page

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 15 Mar 2017 13:21:28 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> I mistakenly added the code to release sk->sk_frag in
> sk_common_release() instead of sk_destruct()
> 
> TCP sockets using sk->sk_allocation == GFP_ATOMIC do no call
> sk_common_release() at close time, thus leaking one (order-3) page.
> 
> iSCSI is using such sockets.
> 
> Fixes: 5640f7685831 ("net: use a per task frag allocator")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks Eric.