netdev - Re: [RFC v1 for accelerated IPoIB 04/25] IB/verb: Add ipoib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170315063043.GC2079@mtr-leonro.local>
Date:   Wed, 15 Mar 2017 08:30:43 +0200
From:   Leon Romanovsky <leonro@...lanox.com>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>
CC:     "Vishwanathapura, Niranjana" <niranjana.vishwanathapura@...el.com>,
        "Erez Shitrit" <erezsh@...lanox.com>, <dledford@...hat.com>,
        <linux-rdma@...r.kernel.org>, <netdev@...r.kernel.org>,
        <valex@...lanox.com>, <saedm@...lanox.com>,
        <erezsh@....mellanox.co.il>
Subject: Re: [RFC v1 for accelerated IPoIB 04/25] IB/verb: Add ipoib_options
 struct and API

On Tue, Mar 14, 2017 at 10:11:49AM -0600, Jason Gunthorpe wrote:
> On Tue, Mar 14, 2017 at 12:01:09AM -0700, Vishwanathapura, Niranjana wrote:
> > On Mon, Mar 13, 2017 at 02:01:36PM -0600, Jason Gunthorpe wrote:
> > >>+	/* multicast */
> > >>+	int (*attach_mcast)(struct net_device *dev, struct ib_device *hca,
> > >>+			    union ib_gid *gid, u16 lid, int set_qkey);
> > >>+	int (*detach_mcast)(struct net_device *dev, struct ib_device *hca,
> > >>+			    union ib_gid *gid, u16 lid);
> > >
> > >It would make more sense to store the struct ib_device pointer in the
> > >struct rdma_netdev.
> > >
> >
> > Agree that it shouldn't be a function parameters.
> > For opa_vnic, I found it convenient to store ib_device pointer in client and
> > device private structures as those will be available in most places anyhow.
>
> If vnic uses it too, then lets add the ib_device and port num to
> rdma_netdev itself?

Agree, at the end this rdma_netdev is intended for the drivers/infiniband
and it is better to have this binding (rdma_netdev and ib_device) as early as possible.

Thanks

>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)