netdev - Re: [net-next 01/13] i40evf: fix client warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170314.173949.1164218813681950110.davem@davemloft.net>
Date:   Tue, 14 Mar 2017 17:39:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     faisal.latif@...el.com, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next 01/13] i40evf: fix client warnings

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue, 14 Mar 2017 15:32:56 -0700

> From: Faisal Latif <faisal.latif@...el.com>
> 
> The function prototype in i40evf_client.h are giving warnings while
> compiling i40iwvf module. Move these function prototypes to i40evf.h.
> Also fix return code from u32 to int and this return code is
> consistent with i40e_client.h
> 
> Change-Id: Ie3757f844993aabc27654aaf02ec14fb985ad2c4
> Signed-off-by: Faisal Latif <faisal.latif@...el.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

There is no such i40evf_client.h header file in the tree.

>  int i40evf_config_rss(struct i40evf_adapter *adapter);
> +int i40evf_lan_add_device(struct i40evf_adapter *adapter);
> +int i40evf_lan_del_device(struct i40evf_adapter *adapter);
> +void i40evf_client_subtask(struct i40evf_adapter *adapter);
> +void i40evf_notify_client_message(struct i40e_vsi *vsi, u8 *msg, u16 len);
> +void i40evf_notify_client_l2_params(struct i40e_vsi *vsi);
> +void i40evf_notify_client_open(struct i40e_vsi *vsi);
> +void i40evf_notify_client_close(struct i40e_vsi *vsi);
>  #endif /* _I40EVF_H_ */

And these functions do not exist in the tree either.

This really isn't acceptable.