netdev - Re: [Patch net] bridge: resolve a false alarm of lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2017 19:36:07 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     avagin@...il.com
Subject: Re: [Patch net] bridge: resolve a false alarm of lockdep

On 16/03/17 19:32, Cong Wang wrote:
> Andrei reported a false alarm of lockdep at net/bridge/br_fdb.c:109,
> this is because in Andrei's case, a spin_bug() was already triggered
> before this, therefore the debug_locks is turned off, lockdep_is_held()
> is no longer accurate after that. We should use lockdep_assert_held_once()
> instead of lockdep_is_held() to respect debug_locks.
> 
> Reported-by: Andrei Vagin <avagin@...il.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  net/bridge/br_fdb.c     | 2 +-
>  net/bridge/br_private.h | 9 ---------
>  2 files changed, 1 insertion(+), 10 deletions(-)
> 

Interesting, thanks Cong!

Fixes: 410b3d48f5111 ("bridge: fdb: add proper lock checks in searching functions")

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>