netdev - Re: [PATCH] tun: fix inability to set offloads after disabling them via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADS+iDWhMQRRNke576R0x4h9Qrg+YDbUm4VE8bjsbG24_rtNDA@mail.gmail.com>
Date:   Thu, 16 Mar 2017 22:42:18 +0300
From:   Yaroslav Isakov <yaroslav.isakov@...il.com>
To:     netdev@...r.kernel.org
Subject: Re: [PATCH] tun: fix inability to set offloads after disabling them
 via ethtool

Sorry for spamming mailing list, forgot to check via checkpatch.pl,
will resend it one more time

2017-03-16 21:08 GMT+03:00 Yaroslav Isakov <yaroslav.isakov@...il.com>:
> Added missing logic in tun driver, which prevents apps to set
> offloads using tun ioctl, if offloads were previously disabled via ethtool
>
> Signed-of-by: Yaroslav Isakov (yaroslav.isakov@...il.com)
> ---
>  drivers/net/tun.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 34cc3c5..cc88cd7 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -1931,6 +1931,8 @@ static int set_offload(struct tun_struct *tun, unsigned long arg)
>                 return -EINVAL;
>
>         tun->set_features = features;
> +       tun->dev->wanted_features &= ~TUN_USER_FEATURES;
> +       tun->dev->wanted_features |= features;
>         netdev_update_features(tun->dev);
>
>         return 0;
> --
> 2.10.2
>