netdev - Re: [PATCH net-next 2/2] net/sched: fq_codel: Avoid set-but-unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d2c7335-2b0b-d199-9392-35ac50e0d430@cogentembedded.com>
Date:   Thu, 16 Mar 2017 13:10:29 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Or Gerlitz <ogerlitz@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net/sched: fq_codel: Avoid set-but-unused
 variable

Hello!

On 3/16/2017 11:49 AM, Or Gerlitz wrote:

> The code introduced by commit 2ccccf5fb "net_sched: update hierarchical
> backlog too" only sets prev_backlog in fq_codel_dequeue() but not

    Need 12 hex digits and () around "<summary>"; see 
Documentation/process/submitting-patches.rst.

> using that anywhere, remove that setting.
>
> Cc: Cong Wang <xiyou.wangcong@...il.com>
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
[...]

MBR, Sergei