netdev - Re: [PATCH net-next V2 2/2] net/sched: fq_codel: Avoid set-but-unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1489667289.28631.219.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Thu, 16 Mar 2017 05:28:09 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Or Gerlitz <ogerlitz@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next V2 2/2] net/sched: fq_codel: Avoid
 set-but-unused variable

On Thu, 2017-03-16 at 12:53 +0200, Or Gerlitz wrote:
> The code introduced by commit 2ccccf5fb43f ("net_sched: update
> hierarchical backlog too") only sets prev_backlog in fq_codel_dequeue()
> but not using that anywhere, remove that setting.
> 
> Cc: Cong Wang <xiyou.wangcong@...il.com>
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> ---
>  net/sched/sch_fq_codel.c | 2 --
>  1 file changed, 2 deletions(-)

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks !