netdev - Re: [PATCH net-next] liquidio: use meaningful names for IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170316.202043.1747040871993595115.davem@davemloft.net>
Date:   Thu, 16 Mar 2017 20:20:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com,
        ricardo.farrington@...ium.com
Subject: Re: [PATCH net-next] liquidio: use meaningful names for IRQs

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Mon, 13 Mar 2017 12:58:04 -0700

> From: Rick Farrington <ricardo.farrington@...ium.com>
> 
> All IRQs owned by the PF and VF drivers share the same nondescript name
> "octeon"; this makes it difficult to setup interrupt affinity.
> 
> Change the IRQ names to reflect their specific purpose:
> 
>     LiquidIO<id>-<func>-<type>-<queue pair num>
> 
> Examples:
>     LiquidIO0-pf0-rxtx-3
>     LiquidIO1-vf1-rxtx-0
>     LiquidIO0-pf0-aux
> 
> We cannot use netdev->name for naming the IRQs because:
> 
>     1.  Early during init, the PF and VF drivers require interrupts to
>         send/receive control data from the NIC firmware; so the PF and VF
>         must request IRQs long before the netdev struct is registered.
> 
>     2.  The IRQ name can only be specified at the time it is requested.
>         It cannot be changed after that.
> 
> Signed-off-by: Rick Farrington <ricardo.farrington@...ium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>
> Signed-off-by: Satanand Burla <satananda.burla@...ium.com>

Applied, thank you.