netdev - Re: [PATCH 0/5] mm subsystem refcounter conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170318163702.GA23796@gondor.apana.org.au>
Date:   Sun, 19 Mar 2017 00:37:02 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     elena.reshetova@...el.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, peterz@...radead.org,
        gregkh@...uxfoundation.org, viro@...iv.linux.org.uk,
        catalin.marinas@....com, mingo@...hat.com, arnd@...db.de,
        luto@...nel.org, "David S. Miller" <davem@...emloft.net>,
        netdev@...r.kernel.org
Subject: Re: [PATCH 0/5] mm subsystem refcounter conversions

Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> The performance implications of this proposal are terrifying.
> 
> I suggest adding a set of non-debug inlined refcount functions which
> just fall back to the simple atomic.h operations.
> 
> And add a new CONFIG_DEBUG_REFCOUNT.  So the performance (and code
> size!) with CONFIG_DEBUG_REFCOUNT=n is unaltered from present code. 
> And make CONFIG_DEBUG_REFCOUNT suitably difficult to set.

I agree.  Refcounts are used in many performance-critical sites
within the network subsystem.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt