netdev - Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALx6S343iWzOKrKwHquG8qmyLyKOgQr_KroHyypE_9MFt2+1BQ@mail.gmail.com>
Date:   Sat, 18 Mar 2017 10:44:02 -0700
From:   Tom Herbert <tom@...bertland.com>
To:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        netdev-owner@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp
 and udp

On Sat, Mar 18, 2017 at 10:32 AM, Subash Abhinov Kasiviswanathan
<subashab@...eaurora.org> wrote:
>> All these hypotheses are quite testable, and it should be obvious that
>> if a patch is supposed to improve performance there should be some
>> effort to quantify the impact.
>
>
> Hi Tom
>
> I ran a single stream unconnected UDPv4 test on an ARM64 system and I see
> a slight increase in performance (782 -> 788Mbps) with udp demux disabled.
> A rudimentary app which does a sendto/recvfrom along with some
> statistics collection was used for this.
>
Less than 1% performance improvement in a benchmark doesn't justify
the complexity of the patch. Eric's hypothesis was that an unconnected
UDP socket may show issues because of cache misses in look-ups due to
so many different sources. This should be fairly easy to benchmark by
randomly setting source address in your test (IP any and routing my
need to be set appropriately).

> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>
> a Linux Foundation Collaborative Project