netdev - Re: [PATCH net] sctp: define dst_pending_confirm as a bit in sctp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170318190708.GB14004@neilslaptop.think-freely.org>
Date:   Sat, 18 Mar 2017 15:07:08 -0400
From:   Neil Horman <nhorman@...driver.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        davem@...emloft.net,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Vlad Yasevich <vyasevich@...il.com>, ja@....bg
Subject: Re: [PATCH net] sctp: define dst_pending_confirm as a bit in
 sctp_transport

On Sat, Mar 18, 2017 at 07:27:23PM +0800, Xin Long wrote:
> As tp->dst_pending_confirm's value can only be set 0 or 1, this
> patch is to change to define it as a bit instead of __u32.
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---
>  include/net/sctp/structs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index 07a0b12..4f64519 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -753,6 +753,8 @@ struct sctp_transport {
>  		/* Is the Path MTU update pending on this tranport */
>  		pmtu_pending:1,
>  
> +		dst_pending_confirm:1,	/* need to confirm neighbour */
> +
>  		/* Has this transport moved the ctsn since we last sacked */
>  		sack_generation:1;
>  	u32 dst_cookie;
> @@ -806,8 +808,6 @@ struct sctp_transport {
>  
>  	__u32 burst_limited;	/* Holds old cwnd when max.burst is applied */
>  
> -	__u32 dst_pending_confirm;	/* need to confirm neighbour */
> -
>  	/* Destination */
>  	struct dst_entry *dst;
>  	/* Source address. */
> -- 
> 2.1.0
> 
> 
Acked-by: Neil Horman <nhorman@...driver.com>