netdev - Re: [PATCH v3 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17d44419-a9db-1822-985e-619083e999b9@grimberg.me>
Date:   Sun, 19 Mar 2017 18:12:31 +0200
From:   Sagi Grimberg <sagi@...mberg.me>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     linux-nvme@...ts.infradead.org, netdev@...r.kernel.org,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v3 0/4] Introduce a new helper for parsing ipv[4|6]:port
 to socket address


>> Changes from v1:
>> - rebased to 4.11-rc1
>> - improved changelogs
>>
>> Changes from v0:
>> - rebased on 4.10
>> - splitted inet_pton_with_scope to be a bit saner (from Chrsitoph)
>> - converted nvme-rdma host_traddr to use a generic helper
>>
>> We have some places in the stack that support ipv4 and ipv6. In
>> some cases the user configuration does not reveal which
>> address family is given and needs to be parsed from the input string.
>>
>> Given that the user-input varies between subsystems, some processing
>> is required from the call-site to separate address and port strings.
>>
>> As a side-effect, this set adds ipv6 support for nvme over fabrics.
>
> Hi Dave,
>
> This set got review tags from two kernel maintainers but this is your
> realm so I wouldn't be comfortable moving forward with this without
> your feedback.

Would it be possible to get a review from one of the netdev folks
on patch 1/4?