netdev - Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58CFF5D0.8040708@iogearbox.net>
Date:   Mon, 20 Mar 2017 16:31:28 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Zi Shen Lim <zlim.lnx@...il.com>,
        "David S . Miller" <davem@...emloft.net>
CC:     Alexei Starovoitov <ast@...nel.org>, Shuah Khan <shuah@...nel.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2

On 03/20/2017 07:03 AM, Zi Shen Lim wrote:
> Merge of 'linux-kselftest-4.11-rc1':
>
> 1. Partially removed use of 'test_objs' target, breaking force rebuild of
> BPFOBJ, introduced in commit d498f8719a09 ("bpf: Rebuild bpf.o for any
> dependency update").
>
>    Update target so dependency on BPFOBJ is restored.
>
> 2. Introduced commit 2047f1d8ba28 ("selftests: Fix the .c linking rule")
> which fixes order of LDLIBS.
>
>    Commit d02d8986a768 ("bpf: Always test unprivileged programs") added
> libcap dependency into CFLAGS. Use LDLIBS instead to fix linking of
> test_verifier.
>
> 3. Introduced commit d83c3ba0b926 ("selftests: Fix selftests build to
> just build, not run tests").
>
>    Reordering the Makefile allows us to remove the 'all' target.
>
> Tested both:
>      selftests/bpf$ make
> and
>      selftests$ make TARGETS=bpf
> on Ubuntu 16.04.2.
>
> Signed-off-by: Zi Shen Lim <zlim.lnx@...il.com>

Looks reasonable to me as follow up to 1da8ac7c49fb ("selftests/bpf:
fix broken build"), thanks for fixing Zi!

Acked-by: Daniel Borkmann <daniel@...earbox.net>
Tested-by: Daniel Borkmann <daniel@...earbox.net>