netdev - Re: [PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when snmp_trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02f61fe0-37d9-8837-1c8f-390c5dea6ff4@cogentembedded.com>
Date:   Mon, 20 Mar 2017 13:09:00 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     fgao@...ai8.com, pablo@...filter.org, davem@...emloft.net,
        jolsa@...hat.com, netfilter-devel@...r.kernel.org,
        netdev@...r.kernel.org, gfree.wind@...il.com
Subject: Re: [PATCH nf v2 1/1] netfilter: snmp: Fix one possible panic when
 snmp_trap_helper fail to register

On 3/20/2017 12:55 PM, fgao@...ai8.com wrote:

> From: Gao Feng <fgao@...ai8.com>
>
> In the commit <93557f53e1fb> ("netfilter: nf_conntrack: nf_conntrack snmp

    Angle brackets not needed. :-)
    The commit citing style is the same as for the Fixes: tag.

> helper"), the snmp_helper is replaced by nf_nat_snmp_hook. So the
> snmp_helper is never registered. But it still tries to unregister the
> snmp_helper, it could cause the panic.
>
> Now remove the useless snmp_helper and the unregister call in the
> error handler.
>
> Fixes: 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp helper")
>
> Signed-off-by: Gao Feng <fgao@...ai8.com>
[...]

MBR, Sergei