netdev - Re: [PATCH nf 1/1] netfilter: snmp: Fix one possible panic when snmp_trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+6hz4qqSnBDFuNQNkBGpaEc1t2o+o6+TDKN4rZWcwjygxcXWA@mail.gmail.com>
Date:   Mon, 20 Mar 2017 17:57:21 +0800
From:   Feng Gao <gfree.wind@...il.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>, jolsa@...hat.com,
        "David S. Miller" <davem@...emloft.net>,
        Netfilter Developer Mailing List 
        <netfilter-devel@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH nf 1/1] netfilter: snmp: Fix one possible panic when
 snmp_trap_helper fail to register

On Mon, Mar 20, 2017 at 5:37 PM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello!
>
> On 3/20/2017 4:44 AM, fgao@...ai8.com wrote:
>
>> From: Gao Feng <fgao@...ai8.com>
>>
>> In the commit ("netfilter: nf_conntrack: nf_conntrack snmp helper"),
>
>
>    Need to specify the 12-digit SHA1 ID as well.

Thanks Sergei.
I didn't know it is asked to add SHA1 ID into description, thanks your reminder.

I have sent the v2 patch.

Regards
Feng

>
>> the snmp_helper is replaced by nf_nat_snmp_hook. So the snmp_helper
>> is never registered. But it still tries to unregister the snmp_helper,
>> it could cause the panic.
>>
>> Now remove the useless snmp_helper and the unregister call in the
>> error handler.
>>
>> Fixes: 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp helper")
>>
>> Signed-off-by: Gao Feng <fgao@...ai8.com>
>
> [...]
>
> MBR, Sergei
>