netdev - Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets and bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170320121619.GA12091@splinter.mtl.com>
Date:   Mon, 20 Mar 2017 14:16:19 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Jiri Pirko <jiri@...lanox.com>, Ido Schimmel <idosch@...lanox.com>,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum: fix swapped order of arguments packets
 and bytes

On Mon, Mar 20, 2017 at 11:37:22AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are
> in the wrong order. Fix this by swapping them.
> 
> Detected by CoverityScan, CID#1419705 ("Arguments in wrong order")
> 
> Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for TC flower offload statistics")

Only need first 12 characters.

> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Ido Schimmel <idosch@...lanox.com>

Thanks!