netdev - liquidio: coverity scan errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170320080221.305727fa@xeon-e3>
Date:   Mon, 20 Mar 2017 08:02:21 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     derek.chickles@...iumnetworks.com,
        satananda.burla@...iumnetworks.com,
        felix.manlunas@...iumnetworks.com,
        raghu.vatsavayi@...iumnetworks.com
Cc:     netdev@...r.kernel.org
Subject: liquidio: coverity scan errors

This showed up new Coverity scan erros
** CID 1403160:    (FORWARD_NULL)
/drivers/net/ethernet/cavium/liquidio/lio_main.c: 802 in setup_glists()
/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c: 560 in setup_glists()


________________________________________________________________________________________________________
*** CID 1403160:    (FORWARD_NULL)
/drivers/net/ethernet/cavium/liquidio/lio_main.c: 802 in setup_glists()
796     	 */
797     	lio->glists_virt_base = kcalloc(num_iqs, sizeof(*lio->glists_virt_base),
798     					GFP_KERNEL);
799     	lio->glists_dma_base = kcalloc(num_iqs, sizeof(*lio->glists_dma_base),
800     				       GFP_KERNEL);
801     
>>>     CID 1403160:    (FORWARD_NULL)
>>>     Comparing "lio->glists_dma_base" to null implies that "lio->glists_dma_base" might be null.  
802     	if (!lio->glists_virt_base || !lio->glists_dma_base) {
803     		delete_glists(lio);
804     		return -ENOMEM;
805     	}
806     
807     	for (i = 0; i < num_iqs; i++) {
/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c: 560 in setup_glists()
554     	 */
555     	lio->glists_virt_base = kcalloc(num_iqs, sizeof(*lio->glists_virt_base),
556     					GFP_KERNEL);
557     	lio->glists_dma_base = kcalloc(num_iqs, sizeof(*lio->glists_dma_base),
558     				       GFP_KERNEL);
559     
>>>     CID 1403160:    (FORWARD_NULL)
>>>     Comparing "lio->glists_dma_base" to null implies that "lio->glists_dma_base" might be null.  
560     	if (!lio->glists_virt_base || !lio->glists_dma_base) {
561     		delete_glists(lio);
562     		return -ENOMEM;
563     	}
564     
565     	for (i = 0; i < num_iqs; i++) {

** CID 1403161:  Memory - illegal accesses  (OVERRUN)