netdev - Re: [PATCH net 7/8] net/mlx5e: Count GSO packets correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6cd891b-248f-86a7-f28c-2cd7a03929db@fb.com>
Date:   Tue, 21 Mar 2017 07:40:43 -0700
From:   Alexei Starovoitov <ast@...com>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, Or Gerlitz <ogerlitz@...lanox.com>,
        Gal Pressman <galp@...lanox.com>, <kernel-team@...com>
Subject: Re: [PATCH net 7/8] net/mlx5e: Count GSO packets correctly

On 3/21/17 6:59 AM, Saeed Mahameed wrote:
> From: Gal Pressman <galp@...lanox.com>
>
> TX packets statistics ('tx_packets' counter) used to count GSO packets
> as one, even though it contains multiple segments.
> This patch will increment the counter by the number of segments, and
> align the driver with the behavior of other drivers in the stack.
>
> Note that no information is lost in this patch due to 'tx_tso_packets'
> counter existence.
>
> Before, ethtool showed:
> $ ethtool -S ens6 | egrep "tx_packets|tx_tso_packets"
>      tx_packets: 61340
>      tx_tso_packets: 60954
>      tx_packets_phy: 2451115
>
> Now, we will see the more logical statistics:
> $ ethtool -S ens6 | egrep "tx_packets|tx_tso_packets"
>      tx_packets: 2451115
>      tx_tso_packets: 60954
>      tx_packets_phy: 2451115
>
> Fixes: e586b3b0baee ("net/mlx5: Ethernet Datapath files")
> Signed-off-by: Gal Pressman <galp@...lanox.com>
> Cc: kernel-team@...com
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>

thank you for fixing!
Acked-by: Alexei Starovoitov <ast@...nel.org>