netdev - Re: [PATCH 2/2] netfilter: ipvs: Compress return logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <144902e5-76d4-f767-7b86-ba07d57cf5a7@cogentembedded.com>
Date:   Tue, 21 Mar 2017 18:49:59 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     simran singhal <singhalsimran0@...il.com>, pablo@...filter.org
Cc:     kadlec@...ckhole.kfki.hu, davem@...emloft.net,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        gregkh@...uxfoundation.org, outreachy-kernel@...glegroups.com,
        wensong@...ux-vs.org, horms@...ge.net.au, ja@....bg
Subject: Re: [PATCH 2/2] netfilter: ipvs: Compress return logic

Hello!

On 03/21/2017 04:23 PM, simran singhal wrote:

> Simplify function returns by merging assignment and return into
> one command line.

    You mean "one statement"?

> Signed-off-by: simran singhal <singhalsimran0@...il.com>
> ---
>
>  --This is my contribution to the netfilter project of
>    Outreachy Round 14.
>
>  net/netfilter/ipvs/ip_vs_ftp.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
> index d30c327..c93c937 100644
> --- a/net/netfilter/ipvs/ip_vs_ftp.c
> +++ b/net/netfilter/ipvs/ip_vs_ftp.c
> @@ -482,11 +482,8 @@ static struct pernet_operations ip_vs_ftp_ops = {
>
>  static int __init ip_vs_ftp_init(void)
>  {
> -	int rv;
> -
> -	rv = register_pernet_subsys(&ip_vs_ftp_ops);
>  	/* rcu_barrier() is called by netns on error */
> -	return rv;
> +	return register_pernet_subsys(&ip_vs_ftp_ops);
>  }
>
>  /*

MBR, Sergei