netdev - Re: [PATCH net-next] net: bcmgenet: Track per TX/RX rings statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170321.153034.1285790422123768475.davem@davemloft.net>
Date:   Tue, 21 Mar 2017 15:30:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, pgynther@...gle.com,
        jaedon.shin@...il.com, opendmb@...il.com
Subject: Re: [PATCH net-next] net: bcmgenet: Track per TX/RX rings
 statistics

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu, 16 Mar 2017 10:27:08 -0700

> __bcmgenet_tx_reclaim() is currently summing TX bytes/packets in a way
> that is not SMP friendly, mutliples CPUs could run
> __bcmgenet_tx_reclaim() independently and still update stats->tx_bytes
> and stats->tx_packets, cloberring the other CPUs statistics.
> 
> Fix this by tracking per RX and TX rings the number of bytes, packets,
> dropped and errors statistics, and provide a bcmgenet_get_stats()
> function which aggregates everything and returns a consistent output.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks.