netdev - Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3DCEF38C-F8FC-4941-936F-921247E13B78@holtmann.org>
Date:   Tue, 21 Mar 2017 09:20:01 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Eugene Krasnikov <k.eugene.e@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Arnd Bergmann <arnd@...db.de>,
        "open list:BLUETOOTH DRIVERS" <linux-bluetooth@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, wcn36xx@...ts.infradead.org,
        linux-wireless <linux-wireless@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org
Subject: Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to
 rpmsg

Hi Bjorn,

> By moving these client drivers to use RPMSG instead of the direct SMD
> API we can reuse them ontop of the newly added GLINK wire-protocol
> support found in the 820 and 835 Qualcomm platforms.
> 
> As the new (RPMSG-based) and old SMD implementations are mutually
> exclusive we have to change all client drivers in one commit, to make
> sure we have a working system before and after this transition.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
> 
> Based on v4.11-rc3 with Arnd's Kconfig dependency fixes for BT_QCOMSMD
> (https://lkml.org/lkml/2017/3/20/1038).
> 
> drivers/bluetooth/Kconfig                  |  2 +-
> drivers/bluetooth/btqcomsmd.c              | 32 +++++++++----------
> drivers/net/wireless/ath/wcn36xx/Kconfig   |  2 +-
> drivers/net/wireless/ath/wcn36xx/main.c    |  6 ++--
> drivers/net/wireless/ath/wcn36xx/smd.c     | 10 +++---
> drivers/net/wireless/ath/wcn36xx/smd.h     |  6 ++--
> drivers/net/wireless/ath/wcn36xx/wcn36xx.h |  2 +-
> drivers/soc/qcom/Kconfig                   |  4 +--
> drivers/soc/qcom/smd-rpm.c                 | 43 +++++++++++++------------
> drivers/soc/qcom/wcnss_ctrl.c              | 50 +++++++++++++++++-------------
> include/linux/soc/qcom/wcnss_ctrl.h        | 11 ++++---
> net/qrtr/Kconfig                           |  2 +-
> net/qrtr/smd.c                             | 42 ++++++++++++-------------
> 13 files changed, 108 insertions(+), 104 deletions(-)

I think that it is best if Dave takes these directly then and I pull them back down later into our trees. Including the Kconfig fix that I will ACK as well.

Acked-by: Marcel Holtmann <marcel@...tmann.org>

Regards

Marcel