netdev - Re: [PATCH] enic: Store permanent MAC address during probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.20.1703201701590.17033@cisco>
Date:   Mon, 20 Mar 2017 17:33:17 -0700
From:   Govindarajulu Varadarajan <gvaradar@...co.com>
To:     PJ Waskiewicz <pjwaskiewicz@...il.com>
CC:     <netdev@...r.kernel.org>, Christian Benvenuti <benve@...co.com>,
        Govindarajulu Varadarajan <_govind@....com>,
        Neel Patel <neepatel@...co.com>
Subject: Re: [PATCH] enic: Store permanent MAC address during probe()

On Mon, 20 Mar 2017, PJ Waskiewicz wrote:

> From: PJ Waskiewicz <pjwaskiewicz@...il.com>
>
> The permanent MAC address is useful to store for things like ethtool,
> and when bonding with modes such as active/passive or LACP.

Hi Peter,

Is this patch fixing an issue with bonding drive on enic?

> This follows the model of other Ethernet drivers, such as ixgbe.
>

While other drivers set netdev->perm_addr, doesn't this actually come free in
register_netdevice().