netdev - Re: [PATCH net-next] liquidio: fix for vf mac addr command sent to nic firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170321.174839.705889972695947836.davem@davemloft.net>
Date:   Tue, 21 Mar 2017 17:48:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com,
        ricardo.farrington@...ium.com
Subject: Re: [PATCH net-next] liquidio: fix for vf mac addr command sent to
 nic firmware

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Fri, 17 Mar 2017 15:43:26 -0700

> From: Rick Farrington <ricardo.farrington@...ium.com>
> 
> Change to support host<->firmware command return value.
> Fix for vf mac addr state command.
> 1. Added support for firmware commands to return a value:
>    - previously, the returned code overlapped with host codes, thus
>      commands were only returning 0 (success) or -1 (interpreted as
>      timeout)
>    - per 'response_manager.h', the error codes are split into two fields
>      (major/minor) now, firmware commands are grouped into their own
>      'major' group, separate from the host's 'major' group, which allow f/w
>      commands to return any 16-bit value
> 2. The command to set vf mac addr was logging a success message even if
>    command failed.  Now command uses a callback function to log the status
>    message.
> 3. The command to set vf mac addr was not logging a message when set via
>    the host 'ip' command.  Now, the callback function will log an
>    appropriate message.
> 
> Signed-off-by: Rick Farrington <ricardo.farrington@...ium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>
> Signed-off-by: Derek Chickles <derek.chickles@...ium.com>
> Signed-off-by: Satanand Burla <satananda.burla@...ium.com>

Applied, thanks.