netdev - Re: [PATCH v2 net 0/5] net:ethernet:aquantia: Misc fixes for atlantic driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Mar 2017 14:44:33 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Pavel Belous <Pavel.Belous@...antia.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org,
        Simon Edelhaus <Simon.Edelhaus@...antia.com>,
        David Arcari <darcari@...hat.com>
Subject: Re: [PATCH v2 net 0/5] net:ethernet:aquantia: Misc fixes for atlantic
 driver.

On 03/22/2017 02:19 PM, Pavel Belous wrote:
> From: Pavel Belous <pavel.belous@...antia.com>
> 
> The following patchset containg several fixes for aQuantia AQtion driver
> for net tree: A couple fixes for IPv6 and other fixes.
> 
> v1->v2: Fix compilation error (using HW_ATL_A0_TXD_CTL_CMD_IPV6 instead
>         HW_ATL_B0_TXD_CTL_CMD_IPV6).

Since you are fixing bugs, can you add proper Fixes: <12-digit commit>
("Commit subject") tags for each commit?

Also, you may want to fix your subjects to be:

net: ethernet: aquantia: Remove adapter re-opening when MTU changed

Thanks!

> 
> 
> Pavel Belous (5):
>   net:ethernet:aquantia: Remove adapter re-opening when mtu changed.
>   net:ethernet:aquantia: Fix packet type detection (TCP/UDP) for IPv6.
>   net:ethernet:aquantia: Missing spinlock initialization.
>   net:ethernet:aquantia: Fix for LSO with IPv6.
>   net:ethernet:aquantia: Reset is_gso flag when EOP reached.
> 
>  drivers/net/ethernet/aquantia/atlantic/aq_main.c   |  5 -----
>  drivers/net/ethernet/aquantia/atlantic/aq_nic.c    | 23 ++++++++++++++++++----
>  drivers/net/ethernet/aquantia/atlantic/aq_ring.c   |  1 +
>  drivers/net/ethernet/aquantia/atlantic/aq_ring.h   |  3 ++-
>  .../ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c  |  4 ++++
>  .../ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c  |  4 ++++
>  6 files changed, 30 insertions(+), 10 deletions(-)
> 


-- 
Florian