netdev - Re: [PATCH 4.11] genetlink: fix counting regression on ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170322.153915.842535433384366274.davem@davemloft.net>
Date:   Wed, 22 Mar 2017 15:39:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sgruszka@...hat.com
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        xose.vazquez@...il.com, Larry.Finger@...inger.net,
        johannes@...solutions.net
Subject: Re: [PATCH 4.11] genetlink: fix counting regression on
 ctrl_dumpfamily()

From: Stanislaw Gruszka <sgruszka@...hat.com>
Date: Wed, 22 Mar 2017 16:08:33 +0100

> Commit 2ae0f17df1cd ("genetlink: use idr to track families") replaced
> 
> 	if (++n < fams_to_skip)
> 		continue;
> into:
> 
> 	if (n++ < fams_to_skip)
> 		continue;
> 
> This subtle change cause that on retry ctrl_dumpfamily() call we omit
> one family that failed to do ctrl_fill_info() on previous call, because
> cb->args[0] = n number counts also family that failed to do
> ctrl_fill_info().
> 
> Patch fixes the problem and avoid confusion in the future just decrease
> n counter when ctrl_fill_info() fail.
> 
> User visible problem caused by this bug is failure to get access to
> some genetlink family i.e. nl80211. However problem is reproducible
> only if number of registered genetlink families is big enough to
> cause second call of ctrl_dumpfamily().
> 
> Cc: Xose Vazquez Perez <xose.vazquez@...il.com>
> Cc: Larry Finger <Larry.Finger@...inger.net>
> Cc: Johannes Berg <johannes@...solutions.net>
> Fixes: 2ae0f17df1cd ("genetlink: use idr to track families")
> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>

Applied and queued up for -stable, thanks.