netdev - Re: [PATCH net] inet: frag: release spinlock before calling icmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170322.154103.2047938994168800668.davem@davemloft.net>
Date:   Wed, 22 Mar 2017 15:41:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     dvyukov@...gle.com, edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] inet: frag: release spinlock before calling
 icmp_send()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 22 Mar 2017 08:57:15 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Dmitry reported a lockdep splat [1] (false positive) that we can fix
> by releasing the spinlock before calling icmp_send() from ip_expire()
> 
> This is a false positive because sending an ICMP message can not
> possibly re-enter the IP frag engine.
 ...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>

Applied, thanks Eric.